I've killed the app editing UI
I seem to have managed to make my application editing UI unresponsive. I have to refresh the page to be able to interact with it again and then it crashes again. I'm self hosting and might have a problem with my websocket connection.
Still investigating, but adding this as is doesn't seem right that I should be able to kill the stript editing UI in this way 🙂
3 Replies
on what version are you ?
and no the crash have nothing to do with your websocket connection
I fixed a few crash causes today and yesterday evening
I'm on something probably a week old. I'll update and let you know how I get on 🙂
thanks. The reason for those crashes is mostly that:
- svelte has no error handling since it generates straight javascript, if we write code that fails, there is no fallback
- it's normally very rare to write code that fail since one would write typesafe code
- windmill does something very special where it display components that can try to process unsanitized inputs. For instance a table would expect an array but nothing prevent the user from writing a number. We do not want to write any everywhere
- The right thing to do is being defensive and assuming that the input is not necessarily what you want expect and check for it everywhere and put runtime checks
- We normally do this everywhere but there is sometimes a few gaps
- the good news:
- We will get rid of all those crashes eventually (hopefully that was the last one, I haven't faced ones since a long time)
- Those crashes would only ever happen during edition, not use of the apps since during view the shapes are the same and there are less logic involved